-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add touch support #67
Conversation
Fixed documentation type [skip ci]
…ul-react-diagrams into feature/add_touch_support
@antonioru you mentioned in the original issue the use of useMouse from your hooks library, but I was unable to find a reference to it. Let me know if I missed something. |
Marked as WIP for now since it's breaking related to issue #68 |
Hello @joancc Perhaps we can use the same approach in your MR? |
Thanks @antonioru! I think I managed totrack the relevant stuff to useCanvasPanHandlers.js:
I'll recreate the CONSTANTS file in my PR and perhaps ass this mouse/touch logic in a separate hook? I'll look closer at the use of these in your PR, butI think that's the important stuff, right? |
Yes, you're absolutely right: it is very important to support the touch event as indeed I was already working on it: :) Btw, would you mind to target your PR to the |
Closing in favor of #82 |
Description
Add touch support for:
Related Issue
Closes #60
Motivation and Context
Closes #60
How Has This Been Tested?
All existing tests are passing.
Tested on the Chrome mobile simulator on a mac and Safari on an iPad.